refactor: add MissingDataError #394
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tristan-f-r
added
the
refactor
Documentation build overview
Show files changed (4 files in total): 📝 4 modified | ➕ 0 added | ➖ 0 deleted
|
forgot about NODEID
should work this time!
introducing the utility function get_node_columns_separate
tristan-f-r
added
the
P-medium
github-actions
bot
added
merge-conflict
agitter
reviewed
Jan 9, 2026
Collaborator
agitter
left a comment
agitter
left a comment
There was a problem hiding this comment.
Do we need to break the get_node_columns signature? Adding the checks within get_node_* functions makes sense to me, as does the new error type in general. My understanding is that the scope argument exists only so we can pass it through to the error message. That is more readable, but adds overhead in using these functions. The alternative would be to use the stack trace to see which algorithm generated the error.
Those are my initial thoughts before a deep review.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While this only affects actual runtime code with an updated, consistent error message on malformed data, the goal of
MissingDataErroris to create a finer distinction between actual unexpected SPRAS errors and expected one, to further #21 (comment). Closes #393.This breaks the
get_node_columnssignature, requiring updates in other open algorithm PRs.